Is it possible to pass two dir files and assert all files an

Question

Is it possible to pass two dir files and assert all files and directories have the same structure and content

Jim · Answer

Sounds like a fun assertion to write I m not sure that it exists though

sam · Answer

yeah sounds like a useful addition

sam · Answer

`dir1 shouldHaveSomeStrutureAs dir2`

sam · Answer

feel free to call it what you want

sam · Answer

sameContents sameTree etc

LeoColman · Answer

we should differentiate between `deep` `recursive` in a way maybe an optional parameter as well

Javier · Answer

Should I file an issue

Javier · Answer

I am going to create a PR

Javier · Answer

sam · Answer

val p = Runtime getRuntime exec reg query HKU S 1 5 19

sam · Answer

what does that do

Javier · Answer

I called `shouldHaveSameTreeAndContents` to be more explicit feels free to suggest if I should change it

Javier · Answer

I don t know I didn t write that

sam · Answer

oh lol

sam · Answer

you just changed formatting

Javier · Answer

maybe that line is appearing because the format was different in one function

sam · Answer

the name is a touch verbose what about `shouldHaveSameStructure`

Javier · Answer

I rename to that slightly smiling face

Javier · Answer

Done white check mark

sam · Answer

white check mark

sam · Answer

will merge once green

Javier · Answer

< sam> I checking one documentation website is same than another I got issues related to the content of the file can be different ` ` instead of ` ` and so on

Javier · Answer

so I am doing something like this

Javier · Answer

```expectFiles zip actualFiles forEach expect actual gt expect replaceSlash actual replaceSlash when expect extension == gz gt println ` gz` files are ignored expect extension == json gt println ` gz` files are ignored expect isDirectory gt actual shouldBeADirectory expect isFile gt actual shouldHaveSameContentAs actual ```

sam · Answer

the filename or the contents of the file

Javier · Answer

what do you thing if we add a `transform` lambda and `filter` predicate

Javier · Answer

the content inside the file

Javier · Answer

the gradle plugin I use to generate the content

Javier · Answer

generates the files differently in windows vs macos

sam · Answer

the lambdas would work

sam · Answer

I didn t realize we were checking file contents

sam · Answer

I thought were just checking file tree

Javier · Answer

nono tree + content

sam · Answer

I mus have missed that

Javier · Answer

that was the reason I named it `shouldHaveSameTreeAndContents`

sam · Answer

yeah I see now

Jim · Answer

Is this jvm only

Javier · Answer

yeah

sam · Answer

yeah

Javier · Answer

files api is not ready in kmp

Jim · Answer

Should we try to use system fileseperaror

sam · Answer

wanna rename it back slightly smiling face

Javier · Answer

okio is almost there tho

Javier · Answer

nono

Javier · Answer

the function is working fine

Javier · Answer

the merged one

Javier · Answer

technically the files have different content

sam · Answer

I think the name same strucutre only makes sense for file names tree

sam · Answer

not actual contents

Javier · Answer

so what should I do

Javier · Answer

in my case I was thinking if you see feasible I add another function to bypass those issues

sam · Answer

I think if we start comparing file contents we re gonna run into all kinds of issues

Javier · Answer

no no there is no issues with that only if files are generated or something so

sam · Answer

ok

sam · Answer

I still think it s useful to have an assertion that only checks structure too

Javier · Answer

for example this gradle plugin generates html files with ` ` in its content in windows

sam · Answer

right

Javier · Answer

what do you think about three functions

Javier · Answer

structure

Javier · Answer

structure + content

Javier · Answer

structure + content + transform + filtering

sam · Answer

yes that works

sam · Answer

I like that

Javier · Answer

ie `fun File shouldHaveSameStructure file File transform transform T gt Unit filter T gt Boolean `

Javier · Answer

I am going to add them

sam · Answer

ok

Jim · Answer

Can you use mutate instead of transform perhaps

sam · Answer

I think transform is a more common name than mutate

Jim · Answer

Huh I deduced what it did from the type it wasn t clear to me

Jim · Answer

Also `other File`

sam · Answer

Actually yeah what is T

Javier · Answer

yeah you have right

Javier · Answer

should be

sam · Answer

Do like a ByteArray or something

Javier · Answer

filter File File gt boolean

sam · Answer

or file

Javier · Answer

in my case I am filtering all gz files

sam · Answer

why double file on the filter

Javier · Answer

technically you are comparing pairs of files

sam · Answer

It s a filter shouldn t it be File gt Boolean

Javier · Answer

probably having only one file is enough because they should be the same but not sure if there is use case where you can filter using the file B instead of file A or viceversa

Javier · Answer

or even both

Javier · Answer

i e filter a b gt a readLines size == 1 amp amp b readLines size == 2

sam · Answer

I thought the filter function would normalize it

sam · Answer

if it s actuallying comparing the files then call it compare

Javier · Answer

```fun File shouldHaveSameStructure file File filter expect File actual File gt Boolean val expectFiles = this walkTopDown toList val actualFiles = file walkTopDown toList expectFiles shouldBeSameSizeAs actualFiles expectFiles zip actualFiles expect actual gt when filter expect actual gt expect isDirectory gt actual shouldBeADirectory expect isFile gt expect shouldHavePath actual path else gt error There is an unexpected error analyzing file trees ```

Javier · Answer

what do you think

sam · Answer

I wouldn t call it filter Filter implies you are filtering things out Here you are comparing So I would call it compare or isEqual or something

sam · Answer

But other than that I like

Javier · Answer

techncally you are filtering that comparison

sam · Answer

I dunno it doesn t seem right to me

sam · Answer

I know you are filtering the file contents but I d never expect a function called filter to compare two things

Javier · Answer

but the function is not comparing is filtering

Javier · Answer

one sample

Javier · Answer

```fileA shouldHaveSameStructure fileB filter = a b gt a extension == html ```

sam · Answer

so what s b doing here

sam · Answer

you don t use the b arg

Javier · Answer

when it is going to be compared the file a with b if a is a json it is filtered

Javier · Answer

yeah

Javier · Answer

but you can do different comparison

Javier · Answer

ie

Javier · Answer

```fileA shouldHaveSameStructure fileB filter = a b gt a readlines size == 2 || b readlines size == 5 ```

sam · Answer

you re not filtering anything there You re applying a predicate to the files

Jim · Answer

Are we trying to test that two file trees have the same structure ignoring nodes based on some predicate

Javier · Answer

I am removing from the comparison all files with have those predicates

sam · Answer

so you are filtering files FROM the comparison

sam · Answer

If so why can t it just be File gt Boolean

Javier · Answer

it can but a and b can be different so maybe there can be use cases where you need both

Javier · Answer

< Jim> both trees are identical but you can remove from the comparison some files

Javier · Answer

for example a tree generated in windows and a tree generated in macos I want to filter if the file extension is ` gz`

Javier · Answer

what name should I put < sam> compare is weird for me because I am not comparing I am comparing and removing from the comparison

Jim · Answer

Yeah so File gt Boolean makes sense here

Javier · Answer

and about the `filter` name

Jim · Answer

Yeah I think so it should apply the same filter to both files in the comparison but hide that from the tester I think `it` instead of `a b`

sam · Answer

filter is fine if it s File gt Boolean

Javier · Answer

```fun File shouldHaveSameStructure file File filter File gt Boolean val expectFiles = this walkTopDown toList val actualFiles = file walkTopDown toList expectFiles shouldBeSameSizeAs actualFiles expectFiles zip actualFiles expect actual gt when filter expect gt expect isDirectory gt actual shouldBeADirectory expect isFile gt expect shouldHavePath actual path else gt error There is an unexpected error analyzing file trees ```

sam · Answer

if it s File File gt Boolean then filter is odd

sam · Answer

Yep either ```fun File shouldHaveSameStructure file File filter File gt Boolean ``` or ```fun File shouldHaveSameStructure file File filterLhs File gt Boolean filterRhs File gt Boolean ``` If you really really want to filter the two sides separately

Javier · Answer

I like that

Javier · Answer

about `transform` I should do that too

sam · Answer

personally I d keep it simple for now

sam · Answer

can always add more stuff later

Javier · Answer

and about filterLhs and Rhs should be ` amp amp ` or `||` ```filterLhs expect amp amp filterRhs actual gt ```

sam · Answer

|| makes sense to me

Javier · Answer

yep

Javier · Answer

I would like to add the transform one because I need it too I think it can be useful for codegen files comparison where the file content can vary only in separators or something so

sam · Answer

Ok then

Javier · Answer

should I separate the transform there in two transform functions or in this case it is better to have only one transform

sam · Answer

I don t really have an opinion on that so we can just go with whatver you think is best

Javier · Answer

my use case a and b have different content because the codegen so I want to transform the files to be the same if really they are the same and only separators are the problem

Javier · Answer

I think it should be one

sam · Answer

Ok that s cool

Javier · Answer

well technically with the filter functions I can achieve that

Javier · Answer

well no because there is separated

Javier · Answer

```fun File shouldHaveSameStructure file File filterLhs File gt Boolean filterRhs File gt Boolean ```

Javier · Answer

if I remerge them into one there is no need to add another with transform

Javier · Answer

I know understand your `compare` my head did tick