Is withData `TestType.Test` <@U12AGS8JG>? (In the ...

# kotest

[dave08]

Is withData TestType.Test @sam? (In the listener this is the check:

private fun TestCase.isApplicable() = (mode == KoinLifecycleMode.Root && description.isRootTest()) ||
   (mode == KoinLifecycleMode.Test && type == TestType.Test)

[sam]

No its test type container

[dave08]

Oh... so I guess I'll have to add a Container mode to that listener for it to work... thanks!

[sam]

https://github.com/kotest/kotest/issues/2296

[dave08]

Is there some kind of TestType.Leaf?

[sam]

TestType.Test

[sam]

I just said leaf in there to remind myself to call the parameter leaf

[sam]

withData(1,2,3, leaf = true) { }

[sam]

I think that makes more sense than testType = TestType.Test to people who don't know the innards of kotest

[dave08]

🙃 It seems like multiple containers tries starting up Koin multiple times, whereas I'd like the most inner container (the withData) BEFORE the `it`s inside it...

[sam]

yeah that's quite specific

[sam]

if you want to use koin, I would use withData at the root level

[dave08]

I tried using:

private fun TestCase.isApplicable() = (mode == KoinLifecycleMode.Root && description.isRootTest())
        || (mode == KoinLifecycleMode.Test && type == TestType.Test)
        || (mode == KoinLifecycleMode.Container && type == TestType.Container)

in the KoinListener but it doesn't work...

[dave08]

Even with a describeSpec?

[sam]

class Foo : DescribeSpec({
  withData(1,2,3) { }
})

[sam]

that would work with koin

[sam]

basically you can't have nested tests with it

[dave08]

Maybe there should be a DataTestSpec? It seems like there's just too many conditions to work with them... Koin, IsolationMode problems...

[sam]

It's more a problem with nested tests in general

[sam]

Once you start nesting you have to decide what you're going to treat as a single test unit

[sam]

I might rename TestType.TEST to LEAF in 5.0

[sam]

I just copied the junit naming and it's not very clear

[dave08]

Then what would you do about isolation mode instance per leaf?