Another little point... it's a bit confusing to ha...

# kotest

[dave08]

Another little point... it's a bit confusing to have the CodePoints in the same Arb as the actual arbitraries... maybe they should be in a CodePoint companion object?

[sam]

you mean Arb.Codepoints.foo ?

[dave08]

No, just Codepoint.foo... the Arb would just make the line longer...

[sam]

so just a top level object

[sam]

All arbs are currently defined on Arb, for easy discoverability

[dave08]

My point is that they usually are used in combination with Arb.string(..., CodePoint.XXX), although they are Arbs themselves, I wonder if anyone uses them as such. So they could have their own "namespace" to indicate what is available to Arb.string, and they won't interfere with the real Arbs.

[sam]

I see your point, perhaps typealiases ?

[dave08]

My concern is code complete...

[sam]

you want to de-clutter code complete ?

[dave08]

Yeah, and make it clearer what options are available in the two contexts. I don't think a typealias would help, but I guess that deprecated CodePoints on Arb would help migrating and I'd suppose the IDE is smart enough to deprioritize deprecated things.

[sam]

You're probably right that they're never used outside of strings.

[sam]

If you want to move them to a new top level object, and put in deprecated typealiases for backwards compatbility then I would merge that PR

[dave08]

Maybe adding a companion object to CodePoint itself?

[dave08]

And then making them extension functions off it?

[sam]

Yes that seems like a good approach.

[dave08]

It doesn't seem that a typealias can be made as an extension function off Arb.Companion?

[dave08]

I think I might have to leave the original functions as deprecated to delegate to the new ones.

[sam]

Ah ok well that works yeah

[dave08]

In the meantime, I might as well also replace the deprecated Char.toInt() with Char.code?

[dave08]

(in codepoint.kt, I mean)

[sam]

Only if its not 1.5 only

[dave08]

Oh, you're not using any 1.5 in the newer versions? I guess I'll leave them then.

[sam]

Its compiled against 1.5

[sam]

But we don't want to force users off 1.4

[sam]

Saying that actually 5.0 will be 1.5 only

[sam]

So yeah change it

[dave08]

Funny, I tried running StringArbTest, but the IDE couldn't find a.codePoints()?

[dave08]

But the tests passed, so I guess it's a cache problem.

[dave08]

I should do the PR against the master branch?

[sam]

Yes

[dave08]

https://github.com/kotest/kotest/pull/2283

[sam]

looks good