https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
w

wasyl

05/16/2021, 12:19 PM
Another one 😄 https://github.com/kotest/kotest/commit/a0ea126434401074dc8d1839fb986c23a74780c1 this commit didn’t really change anything because I was running tests with Gradle, and this discovery path is not even hit — Gradle (Junit?) passes all requested tests classes already, Kotest just filters them to keep Spec instances. The 4GB of memory that ClassGraph takes is triggered by
detectConfig()
. Disabling jar scanning for it is not reasonable, because jars may provide listeners. So while config discovery is pretty useful, would you consider some other mechanism for that? I know that scanning can be disabled, but then modules wouldn’t be able to provide useful listeners (I think I even requested discovery at one point, to avoid having to declare a merged project config in each module). One thing that comes to mind is allowing everything that can be AutoScanned now to be provided via ServiceLoaders. Locally I just hardcoded our listeners and got that peak memory down from 4GB to 1GB. Bottom line: ClassGraph has significant memory impact, at least with larger projects. It’d be nice to have a way to completely bypass it. Btw in addition to memory usage, it also spawns several threads (in my case 18!) that it never releases.
Out of curiosity, when are tests discovered via classgraph? When running Kotest directly on jars from command line somehow, or from junit maybe?
s

sam

05/16/2021, 3:00 PM
When classes aren't specified
So probably never?
😄 1
As gradle specifies them and so does the intellij plugin
w

wasyl

05/16/2021, 3:15 PM
Makes sense, I wonder if someone managed to run Kotest without specifying test classes 😄
s

sam

05/16/2021, 3:16 PM
Lol i think the package run in intellij does that
w

wasyl

05/16/2021, 3:19 PM
I’ll be honest I almost never use that 😄 And I admit I’m mostly looking for optimisations in my workflow, which is running entire module tests via Gradle and maybe running single test from IDE later on
I can draft service loader support later on but I’m not very familiar with Kotest tests suite so that might take a while
s

sam

05/16/2021, 3:20 PM
If we limit scanning to classes only it should work
Although the ones shipped with kotest itself are in jars
Service loader is JVM only too so must be opt in
😕 1
w

wasyl

05/16/2021, 3:21 PM
Right, I forgot 😕
s

sam

05/16/2021, 3:21 PM
You don't need autoscan. You can already disable it
w

wasyl

05/16/2021, 3:21 PM
If we limit scanning to classes only it should work
We also have listeners in other modules, and the case for scanning was to allow modules to contribute listeners just by adding a dependency on them
s

sam

05/16/2021, 3:22 PM
Right
w

wasyl

05/16/2021, 3:22 PM
And that’s why we can disable autoscan, but will have to register those contributed listeners in each module specifically. Not terrible but still some overhead
s

sam

05/16/2021, 3:22 PM
Service loader as an alternative is absolutely fine
w

wasyl

05/16/2021, 3:23 PM
I’ll see if I can figure out something multiplatform-friendly, or maybe Kotlin folks are working on a Kotlin-specific alternative
s

sam

05/16/2021, 3:23 PM
The include packages setting might be sufficient
w

wasyl

05/16/2021, 3:24 PM
I think I tried that and didn’t see much improvement, but I’m not sure now. I’ll check again, you mean to add option to specify
acceptPackages
argument?
Actually, another option would be to specify listeners/extensions classes names that may be on the classpath and use them if they are. That’s pretty inflexible but not terrible either (I’m just looking for ways to sidestep ClassGraph completely)
s

sam

05/16/2021, 3:26 PM
If we use service loader then the JDK still has to open up the jars to look for the descriptor files
Assuming that classgraph is efficient, using the acceptPackages argument would skip a ton of class scanning
I can add that option in like 5 minutes if you want to try a build
w

wasyl

05/16/2021, 3:28 PM
I already figured out how to prototype things quickly locally 🙂 Got a local build and publish whatever I change
s

sam

05/16/2021, 3:28 PM
Ok, and it made no diff ?
w

wasyl

05/16/2021, 3:29 PM
I don’t recall, I’ll check it later today, gotta afk for a while
👍🏻 1
s

sam

05/16/2021, 3:29 PM
I'll push a change to close down the classgraph threads at least
w

wasyl

05/16/2021, 3:29 PM
Also I still want to hunt down that 1GB of memory early on, I have a feeling is a bit more than needed, but haven’t found it yet. But yeah I’ll try some variants and let you know the results 🙂
👍🏻 1
s

sam

05/16/2021, 3:30 PM
and when you're back later - classgraph is used in two places, so make sure you put acceptPackages in both
w

wasyl

05/16/2021, 7:33 PM
But one is not hit when running from Gradle, right? Anyway I specified packages in both places, with no difference in memory usage, still 4GB
I’ll push a change to close down the classgraph threads at least
That’s my bad, the threads are closed right after scanning, the missing
scanResult.close()
in
detektConfig.kt
is just to clean up some files. I looked at the profiler wrong
s

sam

05/16/2021, 8:05 PM
ok I did update the code to call close in detect anyway