wasyl
05/14/2021, 12:29 PMwasyl
05/14/2021, 12:31 PMDescription
class, specifically chain()
and I think path()
methods. One thing I noticed is with + listOf(this)
could be replaced with + this
. Other than that I cached all the methods that seemed to be operating on strings and were cache’able, and it seems I reduced peak usage by ~1GBwasyl
05/14/2021, 12:31 PMwasyl
05/14/2021, 12:31 PMwasyl
05/14/2021, 12:31 PMwasyl
05/14/2021, 12:34 PMwasyl
05/14/2021, 12:41 PMsam
05/14/2021, 1:02 PMDescription
class is getting deprecated anyway in 4.7sam
05/14/2021, 1:03 PMchristophsturm
05/14/2021, 1:04 PMwasyl
05/14/2021, 1:04 PMforall
that can be made as wellsam
05/14/2021, 1:06 PMwasyl
05/14/2021, 1:07 PMforall(row(…
tests, and not the new API that allows data classessam
05/14/2021, 1:07 PMsam
05/14/2021, 1:07 PMsam
05/14/2021, 1:07 PMchristophsturm
05/14/2021, 1:08 PMsam
05/14/2021, 1:08 PMchristophsturm
05/14/2021, 1:09 PMsam
05/14/2021, 1:09 PMwasyl
05/14/2021, 1:09 PMchristophsturm
05/14/2021, 1:09 PMsam
05/14/2021, 1:09 PMsam
05/14/2021, 1:10 PMsam
05/14/2021, 1:10 PMsam
05/14/2021, 1:11 PMwithData { withData { } }
will give you nested tests, which on the old stuff wouldn'twasyl
05/14/2021, 1:15 PMInt.seconds
etc. apis to whatever they did instead 😞 not funsam
05/14/2021, 1:15 PMchristophsturm
05/14/2021, 1:22 PMsam
05/14/2021, 1:23 PMchristophsturm
05/14/2021, 1:23 PMwasyl
05/14/2021, 1:25 PMsam
05/14/2021, 1:25 PMsam
05/14/2021, 1:26 PMwasyl
05/14/2021, 1:27 PMi guess it could still be a separate librarysomeone already did that 😄 https://github.com/eygraber/kotlin-duration-extensions
christophsturm
05/14/2021, 1:27 PMsam
05/14/2021, 1:29 PMsam
05/14/2021, 1:37 PMchristophsturm
05/14/2021, 1:41 PMsam
05/14/2021, 1:46 PMchristophsturm
05/14/2021, 2:03 PMsam
05/14/2021, 2:04 PMsam
05/14/2021, 2:05 PMchristophsturm
05/14/2021, 2:05 PMsam
05/14/2021, 2:06 PMchristophsturm
05/14/2021, 2:07 PMchristophsturm
05/14/2021, 2:07 PMsam
05/14/2021, 2:09 PMchristophsturm
05/14/2021, 2:11 PMsam
05/14/2021, 2:12 PMchristophsturm
05/14/2021, 2:13 PMwasyl
05/14/2021, 2:15 PMwasyl
05/14/2021, 2:22 PM4.6.0.230-SNAPSHOT
sam
05/14/2021, 2:23 PMsam
05/14/2021, 2:23 PMwasyl
05/14/2021, 2:26 PMmaster #230
.
About speed: I don’t see any significant improvement , both versions finish on average within 1 second of each othersam
05/14/2021, 2:27 PMwasyl
05/14/2021, 2:28 PMwasyl
05/14/2021, 2:30 PMsam
05/14/2021, 2:31 PMwasyl
05/14/2021, 2:32 PMDescription
will be deprecated, will the logic be moved somewhere or be reworked completely?sam
05/14/2021, 2:33 PMwasyl
05/14/2021, 2:33 PMsam
05/14/2021, 2:38 PMwasyl
05/14/2021, 3:45 PMwasyl
05/14/2021, 3:45 PMsam
05/14/2021, 3:46 PMsam
05/14/2021, 3:47 PMwasyl
05/14/2021, 3:48 PMsam
05/14/2021, 3:48 PMsam
05/14/2021, 3:48 PMsam
05/14/2021, 3:48 PMwasyl
05/14/2021, 3:49 PMwasyl
05/14/2021, 3:49 PMTestCase#toString()
calls SuspendLambda.toString()
which triggers tons of kotlin.reflect
stuffsam
05/14/2021, 3:50 PMsam
05/14/2021, 3:50 PMwasyl
05/14/2021, 3:53 PMlog("Executing active test $testCase with context $context")
in TestCaseExecutor:148
sam
05/14/2021, 3:53 PMwasyl
05/14/2021, 3:54 PMsam
05/14/2021, 3:54 PMwasyl
05/14/2021, 3:55 PMTestCaseExecutor:179
for example, I can grab some more unless you’re just replacing all logs everywhere 😄sam
05/14/2021, 3:55 PMsam
05/14/2021, 3:55 PMsam
05/14/2021, 4:01 PMsam
05/14/2021, 4:02 PMwasyl
05/14/2021, 4:07 PMwasyl
05/14/2021, 4:08 PMlog(stringFn)
could still delegate to log(null, stringFn)
?sam
05/14/2021, 4:10 PMsam
05/14/2021, 4:10 PMwasyl
05/14/2021, 4:10 PMsam
05/14/2021, 4:11 PMwasyl
05/14/2021, 4:15 PMsam
05/14/2021, 4:16 PMwasyl
05/14/2021, 4:40 PMsam
05/14/2021, 4:40 PMwasyl
05/14/2021, 4:40 PMwasyl
05/14/2021, 4:41 PMsam
05/14/2021, 4:41 PMwasyl
05/14/2021, 4:41 PMsam
05/14/2021, 4:41 PMsam
05/14/2021, 4:42 PMwasyl
05/14/2021, 4:42 PMsam
05/14/2021, 4:42 PMsam
05/14/2021, 4:43 PMwasyl
05/14/2021, 4:43 PMInstancePerLeaf
strategy)sam
05/14/2021, 4:44 PMsam
05/14/2021, 4:47 PMwasyl
05/14/2021, 4:52 PMsam
05/14/2021, 4:58 PMsam
05/14/2021, 4:58 PMwasyl
05/14/2021, 5:02 PMwasyl
05/14/2021, 5:05 PMsam
05/14/2021, 5:05 PMsam
05/14/2021, 5:06 PMwasyl
05/14/2021, 5:07 PMsam
05/14/2021, 5:07 PMsam
05/14/2021, 5:12 PMkotest.framework.discovery.jar.scan.disable
set to truesam
05/14/2021, 5:12 PMwasyl
05/14/2021, 5:17 PMsam
05/14/2021, 5:17 PMsam
05/14/2021, 5:17 PMsam
05/14/2021, 5:17 PMwasyl
05/14/2021, 5:21 PMwasyl
05/14/2021, 5:23 PMinclude only packages
option? I see some rejectPackages
, if there’s an alternative includePackages
then maybe it would help? But I’m gonna check the newest build firstsam
05/14/2021, 5:23 PMwasyl
05/14/2021, 5:23 PMsam
05/14/2021, 5:23 PMsam
05/14/2021, 5:23 PMsam
05/14/2021, 5:23 PMwasyl
05/14/2021, 5:46 PM"-Dkotest.framework.discovery.jar.scan.disable=true"
propertysam
05/14/2021, 5:49 PMsam
05/14/2021, 5:49 PM