Is it possible to have strict runtime validation to check th

Question

Is it possible to have strict runtime validation to check that the ` typename` field matches the expected type name from schema that the json response doesn t contain unnecessary fields objects

mbonnin · Answer

We could add something like this It wouldn t be too hard I think

mbonnin · Answer

Re ` typename` there s the question of types added on the server after compilation

mbonnin · Answer

Because the ` typename` is unknown doesn t always mean the response is wrong

mbonnin · Answer

Do you have a specific use case in mind

wasyl · Answer

Yes and actually I d like both checks to be off in production slightly smiling face But we have a set of recorded responses for API layer tests UI tests such checks would help us make sure the responses are consistent with the queries

wasyl · Answer

Recording new responses when the queries change is inconvenient because the data inside which we check for and use in UI tests changes too Right now we update the jsons semi manually with some `jq` queries but it s a bit error prone exactly in the two cases I mentioned

mbonnin · Answer

I see Test APIs are the next thing I d like to tackle I m thinking of introducing a DSL so that you don t have to write json but could if you really want to Something like query ``` animal species habitat country on Cat meow habitat temperature ``` Test Code ```val testData = buildQueryData animal = cat species = Cat meow = meeeeooowww habitat = habitat country = France temperature = 22 8 ```

mbonnin · Answer

This `buildQueryData` could also be `buildQueryJson` too if you still want a Json to enqueue in MockServer or something else

wasyl · Answer

I suppose you d only know at runtime that something s missing right Either way looks nice but I m not entirely sure we d like to use that since we do fetch jsons from the server the first time we introduce some query

mbonnin · Answer

gt I suppose you d only know at runtime that something s missing right Most likely yes We could theorically generate all the code to make it compile time checked but that might not be worth it

mbonnin · Answer

gt we do fetch jsons from the server the first time we introduce some query Makes send that s completely fair I guess that d be for users who d prefer to manually construct their json as opposed to recording them

wasyl · Answer

Yeah the sdl looks like a useful thing if someone already creates ` Data` instances manually which we specifically try not to do opting for testing entire jsons instead

mbonnin · Answer

Mind opening an issue on the repo so we keep track of the strict mode

wasyl · Answer

For example our server adds some apollo extensions to the response which now I realise would break the second validation I mentioned originally sweat

mbonnin · Answer

We could validate only the `response data` part

mbonnin · Answer

extensions are in `response extensions` right

mbonnin · Answer

Validating extensions would be another story since there s not a schema for them

wasyl · Answer

Yes in root response object the same level as ` data `

wasyl · Answer