Just updating <https github com joreilly MortyComposeKMM> to kotlinlang #apollo-kotlin

Channels

100daysofcode

100daysofkotlin

100daysofkotlin-2021

androidgithubprojects

cincinnati-user-group

competitive-programming

event21-community-content

java-to-kotlin-refactoring

jvm-ir-backend-feedback

kotlin-multiplatform-contest

kotlinultimatechallenge

myndocs-oauth2-server

naming

navigation-architecture-component

practical-functional-programming

proguard

prozis-android-backup

refactoring-to-kotlin

russian-kotlinasfirst

skia-wasm-interop-temp

stayhungrystayfoolish

swagger-gradle-codegen

tricity-kotlin-user-group

Title

John O'Reilly

07/11/2022, 5:22 PM

Just updating https://github.com/joreilly/MortyComposeKMM to Apollo 3.4.0 and getting following error

extra.graphqls: (36, 30): Unknown argument `field` on directive 'nonnull'

The section it's referring to is as follows....was there change made related to this?

extend type Episode @nonnull(field: """
id
name
air_date
episode
characters
created
""")

👀 1

The previous version this was on was

3.3.0

so could be related to change between that and

3.4.0

mbonnin

07/11/2022, 5:27 PM

There were definitely changes around this. We used to not validate directives at all and introduced some validation as part of 3.3.1 IIRC

Let me check MortyComposeKMM

You'll need to use

fields

instead of

field

The directive definition is there

extend type Episode @nonnull(fields: """
id
name
air_date
episode
characters
created
""")

John O'Reilly

07/11/2022, 5:32 PM

ah, nice, thanks....that works now

looks like other ones had

fields

but had typo in this one

mbonnin

07/11/2022, 5:33 PM

More details at https://github.com/apollographql/apollo-kotlin/pull/4174

TLDR: as we add more directives, we'll need to add more validation and also allow renaming them in case of name clash with existing directives

👍 1

4 Views

#apollo-kotlin Join Slack