https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
c

Chris Fillmore

01/30/2023, 10:10 PM
Would anybody be willing to do a quick code review on this utility function?
@Composable
fun rememberLifecycleEvents(
  lifecycleOwner: LifecycleOwner = LocalLifecycleOwner.current,
): Flow<Lifecycle.Event>
Full implementation:
@Composable
fun rememberLifecycleEvents(
  lifecycleOwner: LifecycleOwner = LocalLifecycleOwner.current,
): Flow<Lifecycle.Event> {
  val scope = rememberCoroutineScope()
  val flow = remember(lifecycleOwner) { MutableSharedFlow<Lifecycle.Event>() }
  DisposableEffect(lifecycleOwner) {
    val observer = LifecycleEventObserver { _, event ->
      scope.launch {
        flow.emit(event)
      }
    }

    lifecycleOwner.lifecycle.addObserver(observer)

    onDispose {
      lifecycleOwner.lifecycle.removeObserver(observer)
    }
  }

  return remember(lifecycleOwner) { flow }
}
Just wondering if I missed anything. And/or if this is good idea / bad idea
It’s expected you would use it like this:
val lifecycleEvents = rememberLifecycleEvents()
LaunchedEffect(lifecycleEvents) {
  lifecycleEvents.collect {
    // Handle lifecycle events
  }
}
k

Kevin Del Castillo

01/30/2023, 10:30 PM
This is my take:
interface LifecycleEffectScope {
    /**
     * Register a [callback] which will be invoked on [Lifecycle.Event.ON_START].
     */
    fun onStart(callback: () -> Unit)

    /**
     * Register a [callback] which will be invoked on [Lifecycle.Event.ON_RESUME].
     */
    fun onResume(callback: () -> Unit)

    /**
     * Register a [callback] which will be invoked on [Lifecycle.Event.ON_PAUSE].
     */
    fun onPause(callback: () -> Unit)

    /**
     * Register a [callback] which will be invoked on [Lifecycle.Event.ON_STOP].
     */
    fun onStop(callback: () -> Unit)

    /**
     * Register a [callback] which will be invoked on [Lifecycle.Event.ON_DESTROY].
     */
    fun onDestroy(callback: () -> Unit)
}

private class LifecycleEffectScopeImpl : LifecycleEffectScope {
    private var onStartCallback: (() -> Unit)? = null
    private var onResumeCallback: (() -> Unit)? = null
    private var onPauseCallback: (() -> Unit)? = null
    private var onStopCallback: (() -> Unit)? = null
    private var onDestroyCallback: (() -> Unit)? = null

    override fun onStart(callback: () -> Unit) {
        onStartCallback = callback
    }

    override fun onResume(callback: () -> Unit) {
        onResumeCallback = callback
    }

    override fun onPause(callback: () -> Unit) {
        onPauseCallback = callback
    }

    override fun onStop(callback: () -> Unit) {
        onStopCallback = callback
    }

    override fun onDestroy(callback: () -> Unit) {
        onDestroyCallback = callback
    }

    val observer = LifecycleEventObserver { _, event ->
        when (event) {
            Lifecycle.Event.ON_START -> onStartCallback?.invoke()
            Lifecycle.Event.ON_RESUME -> onResumeCallback?.invoke()
            Lifecycle.Event.ON_PAUSE -> onPauseCallback?.invoke()
            Lifecycle.Event.ON_STOP -> onStopCallback?.invoke()
            Lifecycle.Event.ON_DESTROY -> onDestroyCallback?.invoke()
            else -> {
                /* no-op */
            }
        }
    }
}

/**
 * A side effect of a composition which registers the callbacks set on [block] using
 * [LifecycleEffectScope] setters, whenever [owner] changes the events observer is disposed in
 * the old [owner] and attached to the new [owner].
 */
@Composable
fun LifecycleEffect(
    owner: LifecycleOwner = LocalLifecycleOwner.current,
    block: LifecycleEffectScope.() -> Unit,
) {
    DisposableEffect(owner) {
        val scope = LifecycleEffectScopeImpl()
        scope.block()
        owner.lifecycle.addObserver(scope.observer)

        onDispose {
            owner.lifecycle.removeObserver(scope.observer)
        }
    }
}
You can use it like this:
LifecycleEffect {
   onStart {
       // ...
   }

   onStop {
       // ...
   }

   // etc
}
c

Chris Fillmore

01/31/2023, 3:48 PM
Ah nice, that’s a good approach too. I like that it is defined as
LifecycleEffect
which is consistent with other effects. The reason I used a Flow is that it is easy to e.g.
drop(1)
if we want effects for every
ON_START
event after the first one.
k

Kevin Del Castillo

01/31/2023, 3:59 PM
True, each approach as its own benefits 👍