https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hiring-french
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
d

David Kubecka

02/05/2023, 8:23 PM
Coroutines newbie question: I want to test the following code:
@Service
class AsyncExecutionManager(val taskExecutor: AsyncTaskExecutor) {

    private val jobs = ConcurrentHashMap<String, JobStatus>()

    fun <T> startJob(jobId: String, job: () -> T) {
        val previousStatus = jobs.put(jobId, JobStatus.RUNNING)
        if (previousStatus != JobStatus.RUNNING) {
            taskExecutor.submit {
                job()
            }
        }
    }
Namely, I want to check that the same job cannot be run twice at the same time. To do that, I mock
AsyncTaskExecutor#submit
(from Spring) by starting a thread that just runs the given
job
lambda, catches exceptions, and stores them to a list which is then checked in the test. The mock looks as follows:
private val asyncManager = AsyncExecutionManager(
        mockk {
            val slot = slot<Runnable>()
            every { submit(capture(slot)) } answers {
                thread {
                    try {
                        slot.captured.run()
                    } catch (e: Exception) {
                        errors.add(e)
                    }
                }
                CompletableFuture.completedFuture(Unit)
            }
        },
    )
And the test itself:
@Test
    fun `starting the same task concurrently`() {
//        asyncManager.startJob(job1) { error("should not happen") }
        asyncManager.startJob(job1) { Thread.sleep(100) }
        asyncManager.startJob(job1) { error("should not happen") }
        expectThat(asyncManager.getJobStatus(job1)).isEqualTo(JobStatus.RUNNING)
        Thread.sleep(100)
        expectThat(errors).isEmpty()
    }
The test passes on my machine but I'm not happy about two of its aspects: • The last sleep which must be there to "wait" for the error-throwing threads to catch and handle the exceptions. Without the sleep, if I uncomment the first thread, the test passes even if it shouldn't. • Using threads instead of coroutines. I wonder if there's a way how to rewrite my test to start a coroutine instead of a thread in the mocked
AsyncTaskExecutor#submit
. The problem is that the method doesn't provide a coroutine scope and I don't know how to provide one. I tried making
job
suspending and using
runBlocking
inside the real
submit
lambda but then the jobs in my test don't run concurrently anymore. So basically there are two questions: • Can coroutines be used in my setup of mocking
AsyncTaskExecutor#submit
? • Is there a more robust way to test my code's correctness, other than collecting errors and waiting "sufficient" time? This question is probably not Kotlin-specific but I hope it might be related to the first question, or even there might be special Kotlin tooling for these kinds of situations.
e

ephemient

02/06/2023, 4:20 AM
how about adapting the coroutine dispatcher to an executor? no mocks required
@Test
fun test() = runTest {
    val dispatcher = coroutineContext[CoroutineDispatcher]!!
    val taskExecutor = ConcurrentTaskExecutor(dispatcher.asExecutor())
    val asyncManager = AsyncExecutionManager(taskExecutor)
d

David Kubecka

02/06/2023, 10:08 AM
Yes, that allows me to replace the mock with explicit taskExecutor! Still, I cannot use coroutine elements inside my jobs (e.g. delay instead of sleep). I guess there's no way that can be achieved while using
AsyncTaskExecutor#submit
, right?
Moreover, it doesn't solve my other problem of detecting a job error in a more robust way than sleeping. In fact, the coroutine solution seems to be a bit further away from exactly because there are no mocks now. Any ideas about that?
e

ephemient

02/06/2023, 8:32 PM
right, there no (sane) way use coroutines inside those jobs. but it should give you a way to avoid sleeping:
runCurrent()
will advance all coroutines to the current time. actually the test dispatcher is single threaded, for consistent behavior across runs, so your jobs should be run anyway
d

David Kubecka

02/07/2023, 3:22 PM
But I don't want single-threaded dispatch. Quite the contrary, I want to allow concurrent execution of jobs. Just this particular test case (I have also others) tests that the same job shouldn't run concurrently multiple times. That's why I have the sleep there - to simulate long running task.
e

ephemient

02/07/2023, 5:33 PM
hmm. you could use multi-threaded dispatchers instead of runTest's TestDispatcher, but honestly you should care more about testing concurrency than parallelism
d

David Kubecka

02/08/2023, 12:15 PM
What do you mean by that? Do you suggest I should structure my test differently?
e

ephemient

02/08/2023, 12:58 PM
yes. even without using coroutines, you can use various
java.util.concurrent
utilities such as
CyclicBarrier
or
Phaser
to observe and control what each runnable is doing, instead of relying on thread sleeps
d

David Kubecka

02/08/2023, 1:07 PM
You are probably talking about the first sleep and I know I can replace that with various synchronization primitives. My original question, though, was about the second sleep which is needed simply to wait for both the second thread (with
error
) and its handler in the mock to finish so that I can check whether there were any errors.