https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hiring-french
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
i

itnoles

03/11/2023, 2:34 AM
https://github.com/facebookincubator/dataclassgenerate is Kotlin Data Class is really that bad for Android APK files?
a

agrosner

03/11/2023, 3:23 AM
It depends. At that scale when you can’t control the reuse of code and apps are so large, then maybe this is useful 🤷‍♂️
Then maybe don’t use data classes if you are worried about it
b

Bryan Buschmann

03/11/2023, 6:18 AM
I also don't understand the "maybe the compiler won't know whether or not the object functions are used".
a

Azamat Murzagalin

03/11/2023, 7:55 AM
It depends. At that scale when you can’t control the reuse of code and apps are so large, then maybe this is useful 🤷‍♂️
100% agree Otherwise optimizing data classes looks like a premature optimization
a

agrosner

03/11/2023, 1:02 PM
It seems more work than just removing data and having the ide generate the equals and hashcode and to string for you if you are truly worried lol
i

ianrumac

03/11/2023, 1:06 PM
At their scale, it makes sense - using data classes just for state means you might have a lot of generated toString/equals/copy that you are not using at all. So this can help reduce that generated overhead if you are not using it. But also, a lot of stuff facebook does is due to their scale - they have to support an insane number of devices while building up on years of legacy, hacks and mystery meat, so I wouldn’t really give too much attention to it.
s

Sergei Rybalkin

03/11/2023, 4:57 PM
Even small problems hit hard at scale. If the audience is interested project’s readme has links to public talks that give an idea of the problem scope at scale and an estimation of data classes residual overhead after optimisers
i

ianrumac

03/11/2023, 5:09 PM
Nice, didn’t see those. Just noticed you’re one of the authors, seems like it was a pretty fun project, nice work 👍
b

Bryan Buschmann

03/11/2023, 5:47 PM
It would be nice if the readme had rudimentary metrics that show the gains and trade offs.
Marking a class as
data
is built-in, trivial, and simple. At what scale does performance become a concern? What is the compile time and run time benefits of implementing this alternate workflow? If I'm a tech manager, what can I use to make a determination that this would be worth the time and effort to migrate?
i

ianrumac

03/11/2023, 6:24 PM
Eh, that’s a quite wide question, since scale can mean different things and different things become concerns depending on your definition of it. I.e. FB has to cover a lot of markets and everyone is the target user, including low-end devices with slow processors, low storage and low amounts of RAM. They operate an all dimensions of scale. With hundreds of modules and a huge app, having just 10% size overhead might cause a huge drop in installs (it can be 10-20-30-300mb) difference. Since this is mostly a dex count optimisation, shaving just 10% off the final dex size can increase user acquisition by a small percentage, which is potentially worth millions of dollars in FB’s case. Compile time here is a smaller tradeoff (yes, it will impact it but caching + fresh builds are done on a CI) for the final app size reduction. It might also reduce your app’s startup time due to the multidex impact, since this way you can avoid it. But for some other apps, scale might mean performance optimisations - i.e. trading apps where speed is of critical importance, and there you might require some other optimisations that would try and “primitivize” data classes, due to the performance impact instatiation has. On some other apps, you might hit the problems of scale as in the amount of data, which requires different optimisation points and you gotta be careful of complexities. Meanwhile, somewhere you only care about a high-value target market and the scaling problem is more oriented on “how can the codebase scale for the amount of developers we have”. I’d suggest as a manager to find the biggest pain points that impact your app’s performance on different levels - your team’s performance (readability? build times?), your app’s performance (from startup to logic to UI) and user acquisition performance and your target market’s constraints (memory?speed?storage?data?), and then the calculation of “is it worth migrating” becomes way easier - time x money to implement vs time x money saved.
b

Bryan Buschmann

03/11/2023, 6:52 PM
All I was looking for was something like described in the linked video. https://archive.fosdem.org/2022/schedule/event/dataclassgenerate_shrinking_kotlin_data_classes/
Where there is a simple byte-code comparison that declares a 60% reduction in bytecode generation. That's a pretty significant number and adds a tremendous amount of weight to the uptake of this process.
i

ianrumac

03/12/2023, 10:50 AM
oh, sorry, thought your questions were more generic oriented