Join Slack
Powered by
IMO your code is far more complex than it needs to...
# codereview
a
Andreas Sinz
07/12/2018, 4:19 PM
IMO your code is far more complex than it needs to be (e.g. temporarily storing data inside the class
tempAdIds
,
currentAdId
, ...) which can lead to nasty race conditions/other kind of bugs later on
a
ar-g
07/13/2018, 9:28 AM
Thanks to pointing this out. I have to store
tempAdIds
somewhere to attach to selected images.
4
Views
Open in Slack
Previous
Next