<@UVAR0DXP0> you closed off the rename inspectors ...

# kotest-contributors

[sam]

@Emil Kantis you closed off the rename inspectors ticket, do you not want to do that anymore ?

[Emil Kantis]

There was very little response in favor of doing it (or not doing it for that matter), so I thought we could drop it

[Emil Kantis]

we could go about adding the shouldForX as aliases if you want?

[sam]

My only reluctance was that the new names weren't much better imo

[sam]

were we changing for the sake of it ?

[sam]

but I agree that inspectors aren't that well known

[sam]

cities.shouldForOne { 
   it.shouldHaveName("Chicago")
   it.shouldHaveState("IL")
}

vs

cities.forOne { 
   it.shouldHaveName("Chicago")
   it.shouldHaveState("IL")
}

[sam]

I would be happy to add shouldForX as aliases to the existing matchers

[Emil Kantis]

I agree that forOne reads better and it’s a lot cleaner. A downside to the aliases would be consistency, and knowing what to prefer.. I still think it would be great for discoverability

[sam]

The aliases won't hurt

[sam]

Just don't deprecate the older ones

[Emil Kantis]

Could adding them as deprecated, with a ReplaceWith each respective forX version serve a purpose? Or do you think that would be bad practice?

[sam]

I'm reluctant to keep deprecating things as people put years into tests

[Emil Kantis]

I mean that the added aliases would be flagged from the get-go.. 🙂

[sam]

Oh i see

[sam]

Interesting

[sam]

What about a rule in the intellij plugin

[Emil Kantis]

Ah, that’s probably better

[Emil Kantis]

that can be toggled off, if user desires to, right

[sam]

Yep

[Emil Kantis]

I really like that idea 🙂

[sam]

Easy too

[Emil Kantis]

I remember seeing something in github regarding someone testing Boolean? like

val x: Boolean? = null
x shouldNotBe true

where the plugin suggested that it should be replaced by

x shouldBe false

Did you pick that one up or perhaps that could be.a good thing to check out to learn a bit about the intellij plugin?

[sam]

I haven't done that one

[sam]

It just needs deleting

[Emil Kantis]

Odd.. I can’t find it anymore either

[sam]

It's a stupid rule

[sam]

It's s good first ticket