<@UVAR0DXP0> what do you think about <https://gith...

# kotest-contributors

[sam]

@Emil Kantis what do you think about https://github.com/kotest/kotest/issues/2541

[Emil Kantis]

I think we have that to some extent? Do you have a particular case we can look at? 🙂

[Emil Kantis]

Or do we just show the first property that failed?

[sam]

We currently show expected was .... actual was .... but for large json its really difficult to see where they differ

[sam]

maybe we keep that and yeah show the first property (or few) that failed along with the json path to them ?

[sam]

that would be sweet

[Emil Kantis]

I’ll have a look 🙂

[sam]

cool

[Jim]

Could we build a git style diff?

[sam]

With the + -

[Emil Kantis]

Isn't that kind of what IntelliJ already produces from the "expected was...", "actual was..."?

[Emil Kantis]

at least if we do it with the expected was <[ { ... }]>, actual was <[ { ... }]> format? 🤔

[sam]

it won't be as clear tho

[sam]

like if a field was missing

[sam]

but certainly better

[sam]

we could do both

[Emil Kantis]

I guess it gets complicated when not being strict in every regard.. e.g. allowing different number formats, type coercion, etc.. then diffs will pop up that don't actually matter as well

[Emil Kantis]

I'll start with the property-printing with json-paths you suggested, and then we can go for another round of feedback once I'm a bit more up-to-speed on it?

[sam]

sure

[Emil Kantis]

We currently show expected was .... actual was .... but for large json its really difficult to see where they differ (edited)

Was this when using shouldMatchJson or shouldEqualJson , (or their underlying matchers)? just asking since i saw you used matchJson in your PR which would not print any help other than expected vs actual

[Emil Kantis]

Example test of `equalJson`: shows path to a missing field, for instance

test("real world json without field") {
         val a = this::class.java.getResourceAsStream("/shopify.json").bufferedReader().readText()
         val b = this::class.java.getResourceAsStream("/shopify_without_field.json").bufferedReader().readText()
         shouldFail {
            a shouldEqualJson b
         }.message.shouldStartWith(
            """At 'products.[0].variants.[0]' object was missing expected field(s) [sku]

[sam]

we should overly format these in my opinion

[sam]

I'd like to see our error messages in 5.1 go on acid

[Emil Kantis]

gotcha 👌