https://kotlinlang.org logo
#python-contributors
Title
# python-contributors
s

SerVB

08/27/2021, 2:43 PM
Current
box-tests-report.tsv
has a problem having it in the repo: it contains unstable values like execution time and sometimes paths to temporary files with random names (in stacktraces). So we are risking to have many changed lines in each PR... Anyway, it doesn't seem very critical to me
true story 1
p

Piotr Krzemiński

08/27/2021, 3:45 PM
Yeah, goos point , I was aware of it when implementing it. We can disable adding columns with timings and make paths relative. It should make the diff much cleaner 👍
s

SerVB

08/27/2021, 3:53 PM
JFTR: paths look like
/tmp/box.testsProject_pythonTest_2313166678231674774/testRootGW41/unitTest_kt42932/js-tests/JS_TESTS/kt42932.kt
, the
2313166678231674774
part is random one
p

Piotr Krzemiński

08/27/2021, 3:54 PM
Ah, in tmp and pseudorandom/with timestamps. In theory this can be addressed as well :)
Remove varying parts from box tests report by krzema12 · Pull Request #29 · krzema12/kotlin-python - should do the job. Once it's pushed, would be nice to rebase your changes on top of this change.
👌 1
s

SerVB

08/27/2021, 7:20 PM
Cool! "Before" and "after" are mixed up, btw 😅
p

Piotr Krzemiński

08/27/2021, 7:21 PM
oops, thx 😄 fixed
FTR, ready for review, finally green in CI
s

SerVB

08/30/2021, 12:31 PM
Thanks. I have some more tasks than usual now, so I guess I will return on Friday
1
👍 1