Piotr Krzemiński
02/01/2023, 9:39 PMVampire
02/02/2023, 10:36 AMPiotr Krzemiński
02/02/2023, 10:38 AMVampire
02/02/2023, 10:38 AMPiotr Krzemiński
02/02/2023, 10:51 AMLeoColman
02/02/2023, 2:42 PMVampire
02/02/2023, 2:54 PMactions/
projects is hopefully close to accept the PR, at least it has several positive reviews.
And those are also Microsoft, just another team. 🙂Piotr Krzemiński
02/02/2023, 8:30 PMVampire
02/02/2023, 8:38 PMPiotr Krzemiński
02/02/2023, 8:42 PMVampire
02/03/2023, 12:50 AMPiotr Krzemiński
02/03/2023, 5:12 AMVampire
02/03/2023, 7:36 AMIf it's not merged and released today, I can publish a patch release in a few days if you really need it fast
Wouldn't have been necessary. But anyway, it was merged and released already. :-)
another interesting case: https://github.com/peter-evans/create-pull-request/issues/1574#issuecomment-1415032011 - the owner is kinda interested in maintaining the typings, but not in his repo(s)
I think same problem as with the MS repo. The text is written wrongly. It focuses on getting the action supported in
github-workflows-kt
. This easily leads to "why should I do their work" thoughts (not with this guy obviously, but he still see the main benefit of the PR to support your lib).
Instead you need to rephrase the text to focus on the benefit for the action you are creating the PR for. That it provides typings for the users and so on. And merely mention as side-effect that libs like yours can use it to generate classes properly. Basically similar to my first comment on the MS PR. The action author needs to mainly see a value for himself, his action, and his users, not for you, having less work to do.Piotr Krzemiński
02/03/2023, 8:01 AMVampire
02/03/2023, 8:27 AMPiotr Krzemiński
02/03/2023, 8:29 AMVampire
02/03/2023, 9:02 AMPiotr Krzemiński
02/03/2023, 9:03 AMVampire
02/03/2023, 4:49 PMPiotr Krzemiński
02/03/2023, 5:24 PMVampire
02/04/2023, 11:03 AMactions/
as unwilling, so that not someone else gets the idea to ask again. :-D@Vampire and others: I'm open to feedback on https://github.com/krzema12/github-actions-typing/wiki/Request
I think I would not completely leave out github-workflows-kt, but indeed mention that it then can use that file to generate classes to conveniently use the action in Kotlin DSL for creating GitHub workflow files. That also shows a nice use-case and might even bring some new users.
Piotr Krzemiński
02/04/2023, 11:15 AMVampire
02/04/2023, 11:19 AMPiotr Krzemiński
02/04/2023, 11:23 AMVampire
02/17/2023, 7:44 AMPiotr Krzemiński
02/17/2023, 8:13 AMVampire
02/17/2023, 8:28 AMPiotr Krzemiński
02/17/2023, 8:36 AMVampire
02/17/2023, 8:57 AMPiotr Krzemiński
02/17/2023, 8:58 AMVampire
02/17/2023, 8:59 AMPiotr Krzemiński
02/17/2023, 8:59 AMVampire
02/17/2023, 9:02 AMPiotr Krzemiński
02/17/2023, 9:02 AMVampire
02/17/2023, 9:02 AMPiotr Krzemiński
02/17/2023, 9:20 AMVampire
04/04/2023, 8:12 AMtype-safe-inputs-and-outputs-wiring
branch to the latest main
Piotr Krzemiński
04/04/2023, 8:13 AMVampire
04/04/2023, 8:15 AMPiotr Krzemiński
04/04/2023, 8:16 AMLeoColman
04/04/2023, 6:11 PMThe hardest part of that probably is getting the access from Sonatype 😄Really? I did that so many times I almost know it by heart. Do you think it's a big pain point? I never wrote a guide for it as I assumed people wouldn't need it.
Vampire
04/04/2023, 6:12 PMPiotr Krzemiński
04/04/2023, 6:31 PMLeoColman
04/04/2023, 6:54 PMVampire
04/04/2023, 6:56 PMLeoColman
04/04/2023, 6:58 PMPiotr Krzemiński
04/04/2023, 7:32 PMLeoColman
04/04/2023, 8:19 PMpublishing {
repositories {
maven("<https://oss.sonatype.org/service/local/staging/deploy/maven2>") {
credentials {
username = getenv("OSSRH_USERNAME")
password = getenv("OSSRH_PASSWORD")
}
}
}
Did you try with that /staging/deploy/maven2 part? I never used nexus publishing, always maven publish.
Damn, that's a situation. I'm no longer confusedpublishing {
repositories {
maven {
val releasesRepoUrl = uri("<https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/>")
val snapshotsRepoUrl = uri("<https://s01.oss.sonatype.org/content/repositories/snapshots/>")
name = "deploy"
url = if (Ci.isRelease) releasesRepoUrl else snapshotsRepoUrl
credentials {
username = System.getenv("OSSRH_USERNAME") ?: ossrhUsername
password = System.getenv("OSSRH_PASSWORD") ?: ossrhPassword
}
}
}
In Kotest it's also with that path https://github.com/kotest/kotest/blob/70d21f85419fe238dd961e54eb41320ab0d40cc8/buildSrc/src/main/kotlin/kotest-publishing-conventions.gradle.kts#L45Vampire
04/05/2023, 7:01 AMPiotr Krzemiński
04/05/2023, 8:21 AMLeoColman
04/05/2023, 2:50 PMthe env vars should be pascalCaseNo fucking way 😂
Vampire
04/05/2023, 2:53 PMJAVA_TOOL_OPTIONS="-Dorg.gradle.project.sonatypePassword=s3cr3t"
🙂type-safe-inputs-and-outputs-wiring
branch to the latest main
🙂Piotr Krzemiński
04/16/2023, 6:23 AMVampire
04/16/2023, 10:40 AMPiotr Krzemiński
04/16/2023, 11:12 AM